QMK Logo QMK Firmware

The goal of the QMK software project is to develop a completely customizable, powerful, and enjoyable firmware experience for any project - keyboard or otherwise - and to provide helpful, encouraging, and kind support and feedback for people with any software development experience.

View on GitHub

Current Version Discord Docs Status GitHub contributors GitHub forks


This project is maintained by QMK collaborators and contributors like you!

Hosted on GitHub Pages — Theme by orderedlist


Change rgblight_get_mode & rgb_matrix_get_mode's return type to uint8_t

rgblight_get_mode()’s return type right now is uint32_t, but upon inspection of its implementation, it’s actually returning rgblight_config_t.mode, which is an uint8_t. The return type should match rgblight_config_t.mode’s.

I’ve grep’d through all the keymaps, there does seem to be a few places where rgblight_get_mode’s return value is being saved into another uint32_t variable. These are probably be OK as they’re just upcasting.

Also updating rgb_matrix_get_mode to return uint8_t for similar reason.